CSR Graph is not displayed in Overview mode.

[LoudSnorer]

Problem:
CSR Graph is not displayed in Overview mode.


Summary
This happens for Resmed machines that don’t have a CSR chart in the Overview display range when OSCAR is opened when the display range is changed using arrow keys or the overview range combo box. This problem continues until OSCAR exits and re-opens.
Resmed AirSense 10 AutoSet from March 2015.


Code inspection showed that this problem may not occur for PB charts (intellipap_loader, and prs1_loader) , but has not been tested.
This problem occurs for all versions of OSCAR tested - v1.1.0-release, v1.1.1, v1.2.0, OSCAR v1.3.1, and OSCAR 1.3.5-alpha.0


Reproduce problem.
The problem was first encountered when I had a CSR event older than 3 months old, and the pinned CSR chart did not appear in the Overview mode. Using the custom range selection different condition were used to verify the problem. The problem occurred with v1.1.0 and other versions so the detail investigation was needed.


Software funcationality.
Overview is responsible for selecting a universal set of charts to be displayed, and then removes the chart if the display range for the chart is empty. This works for Zombie, BMI, and Weight charts. The removed charts are not the chart selection combo, so that the USER does not know about them.
The resmed loader, only creates EventList with a real CSR event. The lack of a CSR EventLists for the 1st opening of overview causes the problem. The other loader create an empty EventList when the are no PB events. The problem is solved with the Resmed Loader always creating a CSR EventList.


Changes.
There is a one line in the resmed loader that fixes the problem, and does not have any risk.
Attempting to solve the problem by any other mechanism would be risky.
The change is ready to deliver.


Any suggestion or thoughts or next steps?


LoudSnorer

[Crimson Nape]

Do you have any CSRs being reported in the Daily screen? If not, it won't be displayed until you do. On the other hand, if you do have them, and it isn't being displayed in the Overview, then look in the lower right of the Overview screen and make sure the CSR graph is checked. One other place to check. Look in the File > Preferences > Events and make sure the 3rd listing down, Cheyne Stokes Respiration, is checked in the Overview column.

[pholynyk]

If I understand it correctly, the problem occurs when you display an Overview chart for an interval that has no CSR spans..., and then change the interval to a span that does have one or more CSR spans. The new Overview display does not include the CSR spans.

The proposed solution is to always create an empty CSR event list. I'd like to think about the ramifications of that.

[LoudSnorer]

You are correct. The overview display range does NOT reference any day that has CSR.
However, when the display range is set to include those days (ei everything), CSR is still not displayed in the overview.

[LoudSnorer]

If I understand it correctly, the problem occurs when you display an Overview chart for an interval that has no CSR spans..., and then change the interval to a span that does have one or more CSR spans. The new Overview display does not include the CSR spans.

The proposed solution is to always create an empty CSR event list. I'd like to think about the ramifications of that.

Other loaders, seem to  always use an PB event list and it will be empty when there are no  PB events. The intellipap_loader.cpp initializes the PB event list along with many other events, such as largeLeak, Snore,ClearAirway, etc...

[sawinglogz]

Are you familiar with git? If so, you can create a fork of the repo, make your change in your fork, then propose a merge request that we can review. It sounds like you've tracked down the issue and know how to fix it.

See https://gitlab.com/pholy/OSCAR-code/-/bl...IBUTING.md for more details.

[pholynyk]

The solution is in LoadCSL. Instead of initialising the CSR variable to nullptr, call AddEventList(...); and then comment out the test for CSR further down.

Is this what you would propose?

[LoudSnorer]

The suggest solution does not solve the real issue that also impacts more than just CSR.


Problem
*CSR pinned on overview tab disappears on the first paint.

Cause
*Charts are automatically permanently disabled for charts that are initially empty
*This problem impacts any chart that is enabled in File => Preferences.

Details
*gGraph does not display layers (paint) when the layer is empty.
*gSummaryChart (layer) initializes empty to false and calculates empty during painting.
Causing empty charts to be permanently disabled.
*Once a chart has been displayed, it will always be displayed even if empty.

Solution
*Enabled painting charts when the DayRange is increased, triggering the empty flag to be recalculated
New non-empty charts will now be permanently displayed
*Overview maintains the largest DayRange used and list of empty charts.
*Overview receive these signals and calls recalculates when largest DayRange is increased.
*gSummaryChart implement recalculate method.
*gSummaryChart implement emit signal when empty flag changes.
*gGraphView implement emit signal when day range changes. (XBounds)

**** IMPORTANT MUST Rebuild makefiles.****
*Remove two Makefiles and execute qmake. (works for linux version).

Changes have been submitted.