error building OSCAR from source: unknown warning option

[timpani]

I have been able to successfully build OSCAR (latest master 326b241) on Big Sur.

I was able to install Qt 5.15.2 using the online installer which seems using to be the latest 5.x. I still get the same error as my original post, however, when I removed the -Werror=stringop-overread option from all 3 places it appears in the Makefile, it produced a working OSCAR--albiet with many warnings that pholynyk mentioned. I did try that same workaround (removing the option from Makefile) with Qt 5.12.8 (per BUILD-mac.md) but it ended up erroring out on something else.

My final working procedure:

1. Install the Qt opensource online installer and choose 5.15.2
2. git clone https://gitlab.com/pholy/OSCAR-code.git
3. cd OSCAR-code
4. mkdir build
5. cd build
6. ~/Qt/5.15.2/clang_64/bin/qmake ../oscar/oscar.pro
7. Edit the Makefile, removing the -Werror=stringop-overread option in all 3 places it occurs
8. make

[timpani]

Oh... one more thing...

The above solution worked on Intel Mac running clang v11.0.5. On M1, which has clang v12.0.5, it would not work unless I removed the -Werror option in Makefile. It was catching a deprecated implicit definition copy and I couldn't figure out what option to add, so I removed the -Werror option altogether.

[sawinglogz]

Thanks for looking at this. For now we're sticking with Qt 5.12.x for official Mac builds, since Qt decided to remove LTS support for any newer open-source versions. As a result, 5.15 is no longer receiving public updates as of January 2021, whereas 5.12 will continue to receive updates until December 2021.

I don't know what version of macOS Arie is currently using for builds, but I still build in a Mojave VM.

At some point we'll need to add support for Qt 6 specifically, but that's a pretty large undertaking.

[A KLERK]

Sorry that I see this thread only five days later...
I make builds for OSCAR on macOS on my old MacBook Air 11" 2013,2014 under macOS Mojave, like Crimson Nape proved was the latest I can use.
Qt is at 5.12.10 and MacOSX10.14.sdk

On my new MacBook Air (M1, 2020) with Big Sur however, I now have tried to build according to @timpany's suggestions.
Installed Qt 5.15.2 and MacOSX11.3.sdk.
It builds fine, so I edited the makefile, removing the -Wnoerror=stringop-overread option three times. (Instead of -Werror).
There were a massive amount of warnings. Unfortunately, it ends with one error:

Code:

../oscar/SleepLib/calcs.cpp:1172:5: error: definition of implicit copy assignment operator for 'TimeValue' is deprecated because it has a user-declared copy constructor [-Werror,-Wdeprecated-copy]
   TimeValue(const TimeValue &copy) {

So, OSCAR.app will not run. What should I do? I did not quite understand what you meant by removing the -Werror option altogether...

[timpani]

Sorry that I see this thread only five days later...
I make builds for OSCAR on macOS on my old MacBook Air 11" 2013,2014 under macOS Mojave, like Crimson Nape proved was the latest I can use.
Qt is at 5.12.10 and MacOSX10.14.sdk

On my new MacBook Air (M1, 2020) with Big Sur however, I now have tried to build according to @timpany's suggestions.
Installed Qt 5.15.2 and MacOSX11.3.sdk.
It builds fine, so I edited the makefile, removing the -Wnoerror=stringop-overread option three times. (Instead of -Werror).
There were a massive amount of warnings. Unfortunately, it ends with one error:

Code:

../oscar/SleepLib/calcs.cpp:1172:5: error: definition of implicit copy assignment operator for 'TimeValue' is deprecated because it has a user-declared copy constructor [-Werror,-Wdeprecated-copy]
   TimeValue(const TimeValue &copy) {

So, OSCAR.app will not run. What should I do? I did not quite understand what you meant by removing the -Werror option altogether...

Yes, on a Mac running clang 11, then just removing the -Wnoerror=stringop-overread worked for me.  I added another update for (see post #12 I think) clang 12 on M1 Mac, remove the -Werror option from all the same lines in the Makefile as well.  I finally got my old 2015 Mac working and is now running Mojave so that's where I build.

[A KLERK]

Indeed I was able to build and run deleting all three Werror strings entirely on my Big Sur M1 MacBook Air. Thank you!

But what is even better: It also works on macOS Monterey on the same machine with the same Qt-version and the latest SDKs, updated by  ... (that is "Apple").

[attachment=35814]



That gives me full confidence for the future!

[timpani]

Yeah, there is still a rocky road ahead with Qt support for Apple Silicone (as it is with any cross-platform framework) since often the hooks go deep into the system. And to get the product out the door, many times the code is not modular enough to easily replace the parts that need to be changed. Apple's success will drive the rest of the industry even more so towards ARM (Even though it's actually the on-chip dedicated engines and RAM that make it so much faster). On the down side, I am using Qt for Python (PyQt) version 6 and I still have to jump through all sorts of Rosetta hoops to get it to run on M1. It will be a while. I don't know what the roadmap looks like as there is no mention of it on their website. I can surmise that it's a very heavy lift as it will be for OSCAR to work with Qt6+. All I can suggest to any software developer of any product is to keep an abstraction layer between what you can and cannot control.

[amafra]

Are you using Qt Creator?  If so, did you turn off the "PreCompile" option?  Overall, I had better luck doing a command line build than I did using Creator.  Also, I gave up on Big Sur and used Mojave to build the Mac version.  There seems to be permission settings in Big Sur that I'm not aware of.

Good luck. I hope you find the problem.

Seams that all issues that I have, you have been trought same problems. I'm on catalina, same issues as the user you replied.
error: unknown warning option '-Werror=stringop-overread' [-Werror,-Wunknown-warning-option]

[Jeff8356]

Look a few posts above this one....

Building on my Mac, after running qmake and generating the Makefile, I have to delete the following entries in the Makefile:

Code:

-Werror -Wno-error=stringop-overread

They are in 3 different locations in the Makefile.  It will still show deprecated errors warnings as it compiles, but it works fine.

[amafra]

I was willing to build from source and see if print works on my macos Catalina.
Thanks for the hint.